test(e2e): account & security UI drives (email-verify signup + scaffolds) - #271

Automated code review (gate-code-review)

Reviewing the diff for runtime-correctness issues only.

• frontend/tests/account-security-e2e.spec.ts:83 — resolveEmailCode runs /\b(\d{6})\b/ over JSON.stringify(await detail.json()), i.e. the entire serialized message object, not just the body. The first standalone 6-digit token wins, so any 6-digit value in headers/metadata (a message-ID fragment, a Size, a date component like 202601, a port) can be returned instead of the actual OTP, silently completing the verify step with the wrong code and failing the test spuriously.

That's the only concrete runtime-correctness issue I'd flag; the remaining active test paths look correct and the other drives are test.fixme(true, …) so their bodies don't execute.

Report-only — this check never blocks merge.

CI Fix: regenerate package-lock.json for packages/security workspace

Root cause: PR #271 added packages/security (the @fuzefront/security-client@0.1.0 workspace) to the root package.json workspaces array, but npm install was never run to update the lock file. This caused all three CI jobs to fail with:

npm error code EUSAGE
npm error Missing: @fuzefront/security-client@0.1.0 from lock file
npm error Missing: @types/node@18.19.0 from lock file
npm error Missing: openapi-typescript@7.13.0 from lock file
npm error Missing: typescript@5.1.6 from lock file

Since npm ci failed first, jest was never installed — which is why the downstream "Run apps routes tests" and "Generate test coverage" steps also failed with exit code 127.

Fix: Ran npm install --package-lock-only to regenerate package-lock.json with the new workspace and its devDependencies. The fix is on branch claude-auto-fix-ci-claude/e2e-account-security-29477915405 (commit 5a207e9).

To apply: merge or cherry-pick that branch into claude/e2e-account-security, or run npm install locally and commit the updated package-lock.json.

CI fix: package-lock.json out of sync with workspaces

Root cause

packages/security (@fuzefront/security-client) is listed in the root package.json workspaces array but was absent from package-lock.json. Every npm ci call failed with a lock-file/package.json sync error before any tests ran — this caused both Identity UI + Security (unit) and Lint & Test (18.x) to fail, and Notify Team failed as a consequence.

Fix

Ran npm install --package-lock-only on branch claude-auto-fix-ci-claude/e2e-account-security-29477909085 to regenerate the lock file. The lock file now includes:

• "packages/security" in the workspace paths list
• node_modules/@fuzefront/security-client symlink entry
• packages/security entry with its devDependencies (@types/node, openapi-typescript, tsup, typescript@5.1.6)

No application code was changed — only package-lock.json.

Branch pushed: claude-auto-fix-ci-claude/e2e-account-security-29477909085 (the fix target for this PR). A human with PR-create permissions needs to open the PR from that branch → claude/e2e-account-security (or you can cherry-pick the commit directly here).

CI Fix: package-lock.json out of sync with packages/security workspace

Root cause: The packages/security workspace (@fuzefront/security-client@0.1.0) was listed in the root package.json workspaces array but its entries were missing from package-lock.json. This caused npm ci to fail at the "Build & start backend" step:

npm error Missing: @fuzefront/security-client@0.1.0 from lock file
npm error Missing: @types/node@18.19.0 from lock file
npm error Missing: openapi-typescript@7.13.0 from lock file
npm error Missing: typescript@5.1.6 from lock file

Fix: Regenerated package-lock.json with npm install --package-lock-only on branch claude-auto-fix-ci-claude/e2e-account-security-29477917282. The fix adds the workspace entry, the symlink, and the pinned @types/node and openapi-typescript entries that packages/security requires.

Please merge branch claude-auto-fix-ci-claude/e2e-account-security-29477917282 into this PR's branch (claude/e2e-account-security) to unblock CI.

CI Fix — gate-frontend-build npm ci failure

Root cause: frontend/package-lock.json was missing nested resolution entries for typescript@5.1.6.

The lock file includes workspace entries for ../packages/chat-client and ../packages/chat-ui, both of which declare typescript: "5.1.6" as an exact devDependency. npm ci requires a resolved node_modules entry for every version it finds referenced in the packages section. The root package-lock.json correctly has nested entries (packages/chat-client/node_modules/typescript → 5.1.6), but the frontend/package-lock.json was missing the equivalent:

• ../packages/chat-client/node_modules/typescript
• ../packages/chat-ui/node_modules/typescript

Fix: Added those two entries (28 lines) to frontend/package-lock.json — no source code or workflow changes.

Fix branch: claude-auto-fix-ci-claude/e2e-account-security-29477949007
Fix commit: 878728d

Automated code review (gate-code-review)

Reviewing for runtime-correctness bugs only.

• frontend/tests/account-security-e2e.spec.ts:159 — The negative test calls guardProviderBoundary(page) but discards the returned violations and never asserts it (unlike the positive test at line 154). The only remaining boundary enforcement is the throw inside the page.on('request'/'framenavigated'/'popup') listeners (line 68), but exceptions thrown inside Playwright event listeners are surfaced as unhandled emitter errors, not failures of the awaited action/test — so a auth.fuzefront.com provider-boundary breach in this test would go effectively undetected (swallowed/ineffective error check).
• frontend/tests/account-security-e2e.spec.ts:100 — text.match(/\b(\d{6})\b/) is run over JSON.stringify of the entire message detail (headers, IDs, timestamps, dates), not the body text, so it can capture a stray standalone 6-digit value instead of the real OTP and submit the wrong code, producing a false failure.

Report-only — this check never blocks merge.

CI fix pushed — branch claude-auto-fix-ci-claude/e2e-account-security-29486590285

Root cause

The Playwright sign-in flow job timed out in both auth-simple.spec.ts and clock-load.spec.ts with:

TimeoutError: page.waitForResponse: Timeout 15000ms exceeded while waiting for event "response"

The tests were watching for response.url().includes('/api/auth/login'), but the frontend's authAPI.login() has already been migrated to call POST /api/v1/security/session (the new provider-agnostic Security API in backend/src/services/api.ts).

The full Security service (backend/security, port 3002) is not started in the CI e2e workflow — only the main backend (port 3001) is started. The main backend had no /api/v1/security/* routes, so every login attempt returned 404, persistSession() was never called, no authToken was set in localStorage, and waitForResponse timed out.

Fix (committed to fix branch)

1. backend/src/routes/securityCompat.ts — new thin shim implementing the minimal Security API surface the frontend needs:

   • GET /methods — capability descriptor (password only)
   • POST /session — bcrypt + JWT login → { status: 'authenticated', token, sessionId, user }
   • GET /session — verify JWT → { user } (used by getCurrentUser() post-login)
   • DELETE /session — 204 logout

   Uses the same JWT secret, bcrypt, and sessions table as the existing /api/auth/login.

2. backend/src/index.ts — mounts the shim at /api/v1/security.

3. frontend/tests/auth-simple.spec.ts + clock-load.spec.ts — waitForResponse filters updated to match /api/v1/security/session (with /api/auth/login kept as fallback).

How to apply

Merge or cherry-pick branch claude-auto-fix-ci-claude/e2e-account-security-29486590285 into this PR branch to unblock CI.